Yusuke Wada

Results 1706 comments of Yusuke Wada

Hi @iamyuu Can't reproduce it with your repro. How about remove `node_modules` and re-run `bun install`?

> Wait, I'm trying importing the repo to [stackblitz](https://stackblitz.com/github/iamyuu/repro-hono-valibot?file=src/index.ts) and the error is gone. The difference is in local using `bun instll` and in stackblitz using `npm install --legacy-peer-deps` (after...

Hi @masnormen Thank for the PR! Please wait a little while, I'll look at it in detail later. This may sound difficult, but I'll see if we can't also validate...

Yeah. We often can't do what we want to do with TypeScript.

Hi @masnormen You are right, type validations seem difficult, so let's not consider it this time. This PR looks good to me, but I am curious about one point about...

@masnormen > But at this point, I think there would be a need to make distinction between a `beforeHook` for the current implemented hook (for request validation) and a new...

@masnormen > Come to think of it, it's better if this before/after hook stuff is implemented in the main Hono first. You are right, maybe we should rethink from the...

Ah, it's just an idea. If we can allow a custom JSON serializer in `c.json()`, we may validate the JSON object in the Response: ```ts app.get('/api', (c) => { return...

Anyway, it's not good to parse the `Response` already created, like this PR. So, the best is to add a *hook* for `c.json()` to access the object before creating `Response`.

@draew6 We cannot know with that much information. Please share the minimal code or project to reproduce.