Yusuke Wada
Yusuke Wada
Hey @EdamAme-x Do you think merging this PR is worth it? If so, please review this.
Hello @usualoma ! What do you think of this optimization?
@usualoma Thanks! I also think this is a "gray area". I'll decide whether to merge later.
Hi @Hill-98 Thank you for the PR. Ideally, [the Node.js Adapter](https://github.com/honojs/vite-plugins/blob/main/packages/dev-server/src/adapter/node.ts) is better to inject `incoming` and `outgoing`, though I don't imagine a good implementation now.
Hi @Hill-98 I'm sorry I'm late. I want to know how you use `getConnInfo` for production. This `getConnInfo` imported from `@hono/vite-dev-server/conninfo` is unavailable in production.
@Hill-98 I got it, so this PR is meaningful. One thing. Can you add the description for this feature in [`README.md`](https://github.com/honojs/vite-plugins/blob/main/packages/dev-server/README.md)? Thanks.
@Hill-98 Thanks! Looks good to me. I'll merge and release a new version.
First, regarding the performance of TypeScript. I've measured the performance in [the same way](https://github.com/honojs/hono/blob/5473682ba0d768c345e2e06e6620fa6d52035fd5/.github/workflows/ci.yml#L210 ) of the CI (it does not work on this PR because of a permission issue)....
Hi @usualoma Thank you for the proposal and the PoC. First of all, I like this feature. Until now, I had always thought that handlers would always return a `Response`...
Another reason I like this feature is that it allows me to write **neatly**. This may be a matter of personal taste, but it makes sense because I have always...