Yusuke Wada comments

Results 1706 comments of


                                            Yusuke Wada

feat(ws): Make WebSocket adapter more changeable

Hi @nakasyou Awesome! This is a good feature and refactors things, and the code is clean. I'll merge this now and include it into a **patch** release since this change...

[zod-openapi] streamSSE from hono/streaming together with @hono/zod-openapi have type issues

This related to https://github.com/honojs/hono/issues/3309

feat(oauth-providers): Allow for refresh tokens to be used via access_type "offline" in Issue/#619

Hi @aaronware Thanks for the PR. I think it would be fine if you tested it with the `npm link` though we should add more test codes. @monoald Do you...

feat(oauth-providers): Allow for refresh tokens to be used via access_type "offline" in Issue/#619

Hi @Titou325 This PR is not progressing, so creating a new PR is okay. If so, I will review it. It would be better if you added proper tests there.

feat(oauth-providers): Allow for refresh tokens to be used via access_type "offline" in Issue/#619

Hi @aaronware Can you still work on this PR? I think this feature is okay, but I want to do two things: * Writing tests * Update README.md If these...

test: introduce build tests

Hi @usualoma I also thought we had to have a measuring bundle/file size like yours. This seems great, but I have another idea. Please wait a bit until I show...

test: introduce build tests

Hey @usualoma Regarding this matter, I think we should first monitor bundle sizes. Ideally, the CI will tell us the current bundle sizes and how they have increased from the...

test: introduce build tests

@Jayllyz Ohh, thanks. Can this compare the result of PR with the main's?

hono-openapi expects `method` parameter to be of a specific type

Hi @bruceharrison1984 @akineko I can't reproduce it, but if we bump up the `openapi3-ts` to the latest version, will it be solved? Here: https://github.com/honojs/middleware/blob/1b641bee14a3f9294640834c3ce6de7298e2f255/packages/zod-openapi/package.json#L47

hono-openapi expects `method` parameter to be of a specific type

Hi @akineko Thanks. You are right. It does not work with setting ` "moduleResolution": "Node", # or "Node10"` . > but due to issues with libraries that don't work with...