tsrc icon indicating copy to clipboard operation
tsrc copied to clipboard

'tsrc log' may be broken

Open lomnido opened this issue 2 years ago • 1 comments

Environment

  • Output of tsrc version: tsrc 3.0.1
  • Operating system: Ubuntu 22.04

Command you ran

tsrc log

Actual output

:: Using workspace in /home/lomnido/tsrc-test/workspace
Traceback (most recent call last):                                                                                           
  File "/home/lomnido/.local/bin/tsrc", line 8, in <module>
    sys.exit(main())
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/cli/main.py", line 27, in wrapped
    main_func(args=args)
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/cli/main.py", line 59, in main
    main_impl(args=args)
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/cli/main.py", line 95, in main_impl
    namespace.run(namespace)
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/cli/log.py", line 99, in run
    collection = process_items(repos, log_collector, num_jobs=num_jobs)
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/executor.py", line 325, in process_items
    res = process_items_parallel(items, task, num_jobs=num_jobs)
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/executor.py", line 336, in process_items_parallel
    return executor.process(items)
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/executor.py", line 284, in process
    outcome = future.result()
  File "/usr/lib/python3.10/concurrent/futures/_base.py", line 451, in result
    return self.__get_result()
  File "/usr/lib/python3.10/concurrent/futures/_base.py", line 403, in __get_result
    raise self._exception
  File "/usr/lib/python3.10/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/executor.py", line 303, in process_item
    result = self.task.process(index, count, item)
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/cli/log.py", line 68, in process
    rc, _ = run_git_captured(repo_path, "rev-parse", self.from_ref, check=False)
  File "/home/lomnido/.local/pipx/venvs/tsrc/lib/python3.10/site-packages/tsrc/git.py", line 252, in run_git_captured
    process = subprocess.Popen(git_cmd, cwd=working_path, **options)
  File "/usr/lib/python3.10/subprocess.py", line 971, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.10/subprocess.py", line 1796, in _execute_child
    self.pid = _posixsubprocess.fork_exec(
TypeError: expected str, bytes or os.PathLike object, not NoneType

Expected result

if '--from FROM' is mandatory, than some kind of "missing argument" message should be reported

lomnido avatar Jan 15 '24 10:01 lomnido

@dmerejkowsky seems to fix this issue in 'fix-log' branch.

lomnido avatar Jul 22 '24 08:07 lomnido