google-cloud-rust icon indicating copy to clipboard operation
google-cloud-rust copied to clipboard

Upcoming tonic upgrade

Open AmeliasCode opened this issue 1 year ago • 4 comments

Tonic has recently under gone a massive refactor to support hyper 1.0. This inevitably requires some effort to support. Fortunately, that effort is fairly low and mostly consists of updating dependencies and resynthesizing the googleapis generated code. I have a branch on my fork that does this already.

Once the tonic update is released I can raise a PR, but this will be a breaking change and folks will have to either update their other dependencies or not update their google-cloud-* dependencies.

What are your thoughts on how to best handle this?

AmeliasCode avatar Jun 18 '24 19:06 AmeliasCode

I have checked the following fixes.

https://github.com/AmeliasCode/google-cloud-rust/compare/main..tonic-update

I think it is ok to update the dependency as the modification has been done to the extent of regenerating google-cloud-googleapis.

I will update tonic and see if there is a problem with the operation too.

yoshidan avatar Jun 24 '24 12:06 yoshidan

Now that tonic v0.12.0 is here, I'm keen to see it adopted by these libraries soon.

We're using google-cloud-pubsub in an Axum server and I think this update is the last thing stopping us from updating to the latest Axum version (with hyper 1.0 support).

BeauGieskens avatar Jul 09 '24 00:07 BeauGieskens

https://github.com/yoshidan/google-cloud-rust/pull/283 We are currently checking for problems in the test environment. Will merge when completed.

yoshidan avatar Jul 09 '24 03:07 yoshidan

Now I released v0.28.0

yoshidan avatar Jul 12 '24 10:07 yoshidan