LiquidFloatingActionButton icon indicating copy to clipboard operation
LiquidFloatingActionButton copied to clipboard

Add ability to change individual icons

Open shotaroikeda opened this issue 9 years ago • 5 comments

I've added the ability to change icon colors so that they display smoothly, updated the podspec to completely support Cocoapods 1.0.1, and removed some build warnings that occured with XCode 7.

The only thing you'll want to check before the merge is the podspec's description and the installation instructions for the README, since it points to me rather than to you.

-Cheers!

shotaroikeda avatar Jun 06 '16 06:06 shotaroikeda

I've also exposed LiquidtableCircle.color so that the user can set them

shotaroikeda avatar Jun 06 '16 06:06 shotaroikeda

I also forgot to update travis to use cocoapods 1.0.1 instead, my mistake

shotaroikeda avatar Jun 06 '16 06:06 shotaroikeda

Thank you for great contribution! It makes an error. Could you fix it?

yoavlt avatar Jun 07 '16 02:06 yoavlt

Unfortunately I don't know how travis works (I've fixed everything up to actually running the tests themselves), but as far as I know it seems like it's failing at the testing stage.

Apparently switching from xcodebuild to xctool fixes this. More info here: https://github.com/travis-ci/travis-ci/issues/5743

shotaroikeda avatar Jun 07 '16 05:06 shotaroikeda

I'm since fixed swift-3 support, though the build still seems to be failing

shotaroikeda avatar Sep 21 '16 15:09 shotaroikeda