queue icon indicating copy to clipboard operation
queue copied to clipboard

ListenCommand added to DI.

Open holdmann opened this issue 9 months ago • 4 comments

ListenCommand added to DI through config

holdmann avatar Apr 18 '25 18:04 holdmann

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.72%. Comparing base (05ab1c0) to head (c7f6e1a).

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #243   +/-   ##
=========================================
  Coverage     95.72%   95.72%           
  Complexity      354      354           
=========================================
  Files            46       46           
  Lines           958      958           
=========================================
  Hits            917      917           
  Misses           41       41           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 18 '25 18:04 codecov[bot]

What does it improve?

xepozz avatar Apr 19 '25 19:04 xepozz

What does it improve?

I use this package outside of the context of yii3, so I have to build the container configuration myself. In order not to do it manually, as a starting point I use di.php. Everything suits for me in this approach except for the absence of the queue:listen command. That's why I created the pull request :)

holdmann avatar Apr 20 '25 18:04 holdmann

Everything suits for me in this approach except for the absence of the queue:listen command

When you add a console command to the DI configuration file it does not mean you add the command to console command loader.

Moreover, when you add class => class association to the DI configuration file you do nothing, because it does not define anything new $container->get($class) can do.

xepozz avatar Apr 22 '25 07:04 xepozz