Envelope trait fixed to be compatible with EnvelopeInterface.
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
[2024-05-26 18:37:09] main.ALERT: Fatal Error (E_COMPILE_ERROR): Declaration of Yiisoft\Queue\Message\IdEnvelope::fromMessage(Yiisoft\Queue\Message\MessageInterface $message): Yiisoft\Queue\Message\IdEnvelope must be compatible with Yiisoft\Queue\Message\EnvelopeInterface::fromMessage(Yiisoft\Queue\Message\MessageInterface $message): Yiisoft\Queue\Message\EnvelopeInterface
Codecov Report
Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
Project coverage is 84.30%. Comparing base (
b47a41f) to head (622d9d1). Report is 8 commits behind head on master.
| Files | Patch % | Lines |
|---|---|---|
| src/Message/EnvelopeTrait.php | 66.66% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #205 +/- ##
============================================
- Coverage 84.65% 84.30% -0.36%
Complexity 372 372
============================================
Files 47 47
Lines 1088 1051 -37
============================================
- Hits 921 886 -35
+ Misses 167 165 -2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @holdmann. I'm sorry for such a long response.
It looks like this bug is already fixed in master. IdEnvelope is used in tests, and they are succeeded. Feel free to open a new issue or create a new PR if you find an error.