db-oracle icon indicating copy to clipboard operation
db-oracle copied to clipboard

ColumnSchema classes for performance of typecasting

Open Tigrov opened this issue 2 years ago • 2 comments

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues yiisoft/db#737

Tigrov avatar Sep 01 '23 13:09 Tigrov

PR Summary

  • Introduced a new file BinaryColumnSchema.php. A new class BinaryColumnSchema has been added to handle complex binary column operations.
  • Deprecation warning in ColumnSchema.php. The direct usage of ColumnSchema class is now discouraged in favor of specific type classes. This class now contains fixes to suppress warnings related to this change.
  • Changes to Schema.php file. This file now has a renamed method, supports a broader range of parameters, and contains new methods for creating column schemas based on different PHP types. The updates encourage better usage of specific type classes and provide more efficient way of working with databases.
  • Improvements to ColumnSchemaTest.php. New test methods have been added to check instances of column schema and to verify the functionality of the new BinaryColumnSchema class. This ensures the reliability of the new changes introduced.
  • Addition of ColumnSchemaProvider.php. This file extends the functionality of its parent class to now use the BinaryColumnSchema class specifically for binary type columns, which improves the handling of these complex data types in our application.

what-the-diff[bot] avatar Sep 01 '23 13:09 what-the-diff[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.99%. Comparing base (e1275ac) to head (9dc9f00). Report is 11 commits behind head on master.

:exclamation: Current head 9dc9f00 differs from pull request most recent head 64f3211

Please upload reports for the commit 64f3211 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #236      +/-   ##
============================================
- Coverage     98.02%   96.99%   -1.03%     
- Complexity      175      195      +20     
============================================
  Files            16       17       +1     
  Lines           556      599      +43     
============================================
+ Hits            545      581      +36     
- Misses           11       18       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 03 '23 12:09 codecov[bot]