react-gallery-carousel icon indicating copy to clipboard operation
react-gallery-carousel copied to clipboard
verified publisher icon yifaneye

shouldMaximizeOnClick doesn't work

Open Ruslan27032000 opened this issue 3 years ago • 1 comments

I have Carousel with shouldMinimizeOnClick and shouldMaximizeOnClick. In mobile version maximize working great, but if I click on toggle device toolbar and click on image it doesn't work.

Steps to reproduce the behavior:

  1. Go to https://yifaneye.github.io/react-gallery-carousel/
  2. Open console and click on "Toggle device toolbar". Choose Some phone(for example IPhone XR)
  3. Scroll down to carousel with shouldMaximizeOnClick
  4. See error

image image

Ruslan27032000 avatar May 19 '22 07:05 Ruslan27032000

Hi @Ruslan27032000 Thanks for raising this issue up! I will investigate!

yifaneye avatar May 24 '22 12:05 yifaneye

Hi @Ruslan27032000 !

This issue is because the touch event is recognized additionally as a mouse event on simulated mobile devices (e.g. Toggle Device Toolbar on Chrome).

It is now fixed in v0.3.0. See the gif below. 😁 issue-74-fixed

yifaneye avatar Oct 15 '22 01:10 yifaneye