react-gallery-carousel icon indicating copy to clipboard operation
react-gallery-carousel copied to clipboard

Add classNameAtMax and stylesAtMax

Open a-tonchev opened this issue 4 years ago • 8 comments

Since we have className and styles for non-maximized view, it should be nice to have also such ones for maximized view.

I love the way material ui is doing this with the classes object:

https://material-ui.com/customization/components/

I think best would be something like

<Carousel
  classnames={{
    thumbnail: classNameOfThumbnail,
    activeThumbnail: classNameOfActiveThumbnail,
    maximizedCarousel: classNameOfMaximizedCarousel,
    image: classNameOfImage,
    imageContainer: classNameOfImageContainer,
    ...etc
  }}
>

a-tonchev avatar Jun 09 '21 08:06 a-tonchev

Hi @a-tonchev ! Thank you for bringing this issue up! 😄

The way you suggested should work great! I will add this probably in v0.3.0.

yifaneye avatar Jun 09 '21 12:06 yifaneye

Hi. Do you gonna release v0.3.0?

Ruslan27032000 avatar Mar 09 '22 16:03 Ruslan27032000

I am a bit busy at the moment. I will work on it this month or the next.

yifaneye avatar Mar 14 '22 07:03 yifaneye

@yifaneye Do you need any help for realization?)

Ruslan27032000 avatar Apr 21 '22 09:04 Ruslan27032000

@Ruslan27032000 Thanks for asking. It will be awesome if you can make a pull request.

yifaneye avatar Apr 26 '22 14:04 yifaneye

@yifaneye I tried to make the right styles but I think you can do it better

Ruslan27032000 avatar May 09 '22 09:05 Ruslan27032000

@Ruslan27032000 Thanks! Please make a pull request, so I can try to enhance it.

yifaneye avatar May 10 '22 13:05 yifaneye

Hi @Ruslan27032000 !

Could you please create a pull request to merge into the master branch?

yifaneye avatar Oct 15 '22 01:10 yifaneye