yearn-protocol [WIP] - chore: add complete interfaces

Fixes: #55

Still a work in progress.

Right now I think I should have the intefaces for Aave and Compound basically complete. One thing I'm wondering that in aave/AaveToken.sol, you seem to have made underlyingAssetAddress into a function whereas in the original Aave tokenization/Atoken.sol, undelyingAssetAddress is a public variable. Do you want all of the public variables in the contracts to be converted into a function?

Oct 29 '20 14:10 tansawit

Side question. How do I pass the commitlint tests?

Oct 29 '20 15:10 tansawit

@tansawit https://www.conventionalcommits.org/en/v1.0.0/

Oct 29 '20 15:10 fubuloubu

@fubuloubu commitlint seems to keep using old commit messages? Specifically "fixed failing tests" and "added complete interfaces". Am I misunderstanding something?

Oct 29 '20 15:10 tansawit

@tansawit you'll have to amend those commit messages to get it to pass (git rebase -i develop)

Oct 29 '20 15:10 fubuloubu

@fubuloubu Thanks! Seems to be working now. Will keep adding to it over the weekend

Oct 29 '20 16:10 tansawit

@tansawit changed title to WIP to simplify for house keeping

Nov 06 '20 20:11 storming0x

@tansawit some time has passed since this PR. You are almost there! Can you make the CI checks pass I think we are good to go

Mar 10 '21 09:03 saltyfacu

@fameal apologies. meant to get back to finishing it much sooner. cleaned it up and the tests are now passing :)

Mar 10 '21 10:03 tansawit

@fubuloubu can we merge?

Mar 10 '21 11:03 saltyfacu

A lot of functions are still missing from curve/dforce/maker/yearn are still missing. I can help add those as well if needed but might not get to it until at least the weekends

Mar 10 '21 12:03 tansawit

Sure, no problem. There's no rush. I'm following up on the PR 💪

Mar 10 '21 14:03 saltyfacu