MISO icon indicating copy to clipboard operation
MISO copied to clipboard

Bug fix for sashimi_plot with --plot-label option

Open tdanhorn opened this issue 8 years ago • 2 comments

This should fix it:

--- lib/python2.7/site-packages/misopy/sashimi_plot/Sashimi.py.old	2017-07-20 16:17:22.000000000 -0600
+++ lib/python2.7/site-packages/misopy/sashimi_plot/Sashimi.py	2018-01-30 19:58:18.320473810 -0700
@@ -88,10 +88,10 @@
         output_fname = None
         if plot_label is not None:
             # Use custom plot label if given
-            ext = self.output_filename.rsplit(".")[0]
+            ext = self.output_filename.rsplit(".")[1]
             dirname = os.path.dirname(self.output_filename)
             output_fname = \
-                os.path.dirname(dirname, "%s.%s" %(plot_label, ext))
+                os.path.join(dirname, "%s.%s" %(plot_label, ext))
         else:
             output_fname = self.output_filename
         print "Saving plot to: %s" %(output_fname)

tdanhorn avatar Jan 31 '18 04:01 tdanhorn

This should fix it:

--- lib/python2.7/site-packages/misopy/sashimi_plot/Sashimi.py.old	2017-07-20 16:17:22.000000000 -0600
+++ lib/python2.7/site-packages/misopy/sashimi_plot/Sashimi.py	2018-01-30 19:58:18.320473810 -0700
@@ -88,10 +88,10 @@
         output_fname = None
         if plot_label is not None:
             # Use custom plot label if given
-            ext = self.output_filename.rsplit(".")[0]
+            ext = self.output_filename.rsplit(".")[1]
             dirname = os.path.dirname(self.output_filename)
             output_fname = \
-                os.path.dirname(dirname, "%s.%s" %(plot_label, ext))
+                os.path.join(dirname, "%s.%s" %(plot_label, ext))
         else:
             output_fname = self.output_filename
         print "Saving plot to: %s" %(output_fname)

I guess reading last element as an extension is better option: ext = self.output_filename.rsplit(".")[-1] cause now you can use dots in names

emir-radkevich avatar May 01 '20 12:05 emir-radkevich

Good point, I agree, thanks!

tdanhorn avatar May 14 '20 19:05 tdanhorn