BYOL-PyTorch icon indicating copy to clipboard operation
BYOL-PyTorch copied to clipboard
verified publisher icon yaox12

Is the sigma_limit of albumentations GaussianBlur correct?

Open SunDoge opened this issue 5 years ago • 3 comments

Hi, thanks for your excellent work!

I'm trying to reproduce BYOL using albumentations transforms. However, I noticed that in

https://github.com/yaox12/BYOL-PyTorch/blob/master/data/byol_transform_a.py#L43

you set the sigma_limit to (0.1, 0.2), instead of (0.1, 2.0). Is it intentional？

SunDoge avatar Dec 25 '20 07:12 SunDoge

This should be a mistake. (0.1, 2.0) is correct.

yaox12 avatar Dec 27 '20 06:12 yaox12

@SunDoge Also to notice that the HueSaturationValue in byol_transform_a.py may not be consistent with the torchvision version. See https://github.com/albumentations-team/albumentations/issues/672 and https://github.com/albumentations-team/albumentations/issues/698 for details.

yaox12 avatar Dec 27 '20 06:12 yaox12

Hi, @yaox12 . Thanks for your suggestion. ColorJitter has been added to albumentations and I replaced RandomBrightnessContrast and HueSaturationValue with it.

SunDoge avatar Dec 27 '20 14:12 SunDoge