react-native-orientation icon indicating copy to clipboard operation
react-native-orientation copied to clipboard

get SDK version from root directory

Open alikazemkhanloo opened this issue 6 years ago • 1 comments

building the release app failed with this error:

\node_modules\react-native-orientation\android\build\intermediates\res\merged\release\values\values.xml:2919: error: resource android:attr/offset not found.

increasing the sdk versions of this library solved the issue for me. This PR tries to get the sdk version from the root project, and in case of error, falls back to older default values.

Also it is good to be compatible with the root project of the users.

alikazemkhanloo avatar Sep 03 '19 21:09 alikazemkhanloo

I'm working on this port for this lib as it seems dead, already applied all the pull requests from here.

https://github.com/YatoStudio/react-native-orientation-handler

lmeireles avatar Sep 13 '19 00:09 lmeireles