yaakovschectman

Results 58 comments of yaakovschectman

Whether additional arbitrary string attributes would be useful for Windows? I'm not aware by memory of any use that would apply to us.

I think this will need a test, but as it tests the initialization of the binding, I will need to determine exactly how to write it.

@gspencergoog How would we be able to test that the framework sends a certain platform message to the engine upon initializing the ServiceBinding? Do we have a way to mock...

@gspencergoog I am unclear on what `TestPlatformDispatcher` you're referring to with regards to this test binding (where `ServiceBinding` is tested): https://github.com/flutter/flutter/blob/2bea17799c6eb6a137c943f4c5b3bc442a587073/packages/flutter/test/services/binding_test.dart#L43

Are you referring to https://github.com/flutter/flutter/blob/2bea17799c6eb6a137c943f4c5b3bc442a587073/packages/flutter/test/widgets/binding_test.dart#L48? What is available at that layer that seems useful to this prospective test?

What are your thoughts on adding to the `windows_startup_test` integration test to ensure that the platform message is sent by binding initialization?

I'm running into some difficulty setting the handler for the platform message on the C++ side, because it has a reference to the standard method codec instance, but not the...

@goderbauer We handle custom window close handlers by listening for the WM_CLOSE message and then sending a message from the engine to the framework to run those handlers and decide...

Through what other means would the engine know whether the framework has set a handler or not?

It is not supposed to indicate the completion of the app initialization, just the binding initialization.