Stu

Results 55 comments of Stu

@SirLouen Is this still relevant? Have you tried using the phpcs and phpcbf commands directly in the terminal to determine whether it's an issue with this extension or the phpcs...

After reviewing this PR, I can confirm that it fixes the linked issue by not adding a new line. > The output from fixer always strips newlines. Fixer always strips...

So the correct implementation is that fixer doesn't trim the stdout since the content could require a trailing whitespace (ie. final new line), and it doesn't add new lines either....

@sklakhani @ultimike The extension has been published to the Open VSX Registry since v0.0.17 (Feb 2024), please download the latest .vsix from there (https://open-vsx.org/extension/ValeryanM/vscode-phpsab). I will update the README to...

@katsu-jin This repo is severely unmaintained. This issue was fixed in my forked repo (among lots of other new features) by replacing the then-unmaintained nategood/httpful package in favour of guzzlehttp/guzzle....

@Spriz I can't replicate the issue in v0.0.20. I'm going to close this issue as can't reproduce, but if it's still an issue, you're more than welcome to reopen with...

After some more testing, I've found that sniffer needs double quoting because `shell: true` is added to the spawn options, therefore no escaping happens on their end. However, the fixer...

@valeryan I've added the comments to both sniffer and fixer. They're a bit extensive, but should make it easier for maintainers to understand why they're different. Also, looking into the...

@valeryan can we get this tested and reviewed, and hopefully merged soon please?

@valeryan All issues are resolved. I believe this PR can be merged now. Tested on Windows 10. Still needs testing on other systems though.