GoogleTagManagerBundle icon indicating copy to clipboard operation
GoogleTagManagerBundle copied to clipboard

Using the "Twig_Extension" class is deprecated since Twig version 2.7

Open poaq opened this issue 5 years ago • 2 comments

any plan to update it?

solution: Twig\Extension\AbstractExtension intsead of twig_extension Twig\TwigFunction instead of Twig_SimpleFunction

create yaml file for config: google_tag_manager.yaml (this info is lack in docs)

poaq avatar May 04 '20 21:05 poaq

@xyNNN would update of twig classes be accepted? That means dropping support for old symphony versions and allow Twig v3.

jkabat avatar Feb 08 '21 08:02 jkabat

@jkabat

We can drop it, sure. My suggestion is to update twig as dependency and create a new major release (3.x) for the new Symfony version, so we can support the old versions with the 2.x release. Feel free to make a pull request 👍 Thanks!

xyNNN avatar Feb 08 '21 13:02 xyNNN