Fix drivers completions
Fixes https://github.com/xo/usql/issues/478
The drivers NewCompleter was removed from the handler between v0.18.1 and v0.19.0. Tested locally, I had to cleanup the dependencies for go to build.
Thanks a lot for working on it! I found that the completer calls were moved from
OpentoNewin 05236d1. We should figure out why, to avoid calling it twice. @kenshaw do you have more context why? Should we revert this one change?
I was thinking to also move the drivers.NewCompleter() call to New but New is missing the context that this function needs.
I moved all completer calls back to Open in https://github.com/xo/usql/pull/481/commits/2ad11cf41940e3fb14f5246e0c63796e5d45d286 to simplify a little but I can revert if you prefer?
At the risk of coming across like a nag, I think bumping this PR seems warranted given that the issue persists and we've seen 15 releases since the proposed fix was submitted for approval. πΆβπ«