Support for more SMS validity period formats
Hello.
If you are interested in accepting pull requests, I implemented encode/decode support for the absolute SMS validity period format as well as support for 2/3 enhanced SMS validity period formats.
I think the main thing you might want to check is the public Message struct.
New parameter fields AbsoluteVP and EnhancedVP for the new formats were added.
This way of adding them is simple and preserves backwards compatibility.
However, if you have any objections, then feel free to propose another way and let's see how to go forwards.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
Attention: Patch coverage is 58.69565% with 38 lines in your changes missing coverage. Please review.
Project coverage is 34.76%. Comparing base (
379970a) to head (8af6aa5). Report is 3 commits behind head on master.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 36.13% 34.76% -1.38%
==========================================
Files 18 21 +3
Lines 1605 1795 +190
==========================================
+ Hits 580 624 +44
- Misses 940 1080 +140
- Partials 85 91 +6
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@xlab a gentle reminder if you might take a look at this at some point.
@ah9142 apologies for the delay, I am actually happy to accept pull requests and new features there. Having more validity period options is a great feat, and thanks for keeping compatibility.
I don't have unfortunately hardware means to validate this, but if it works for you that's cool!
No problem. I haven't been working on anything at related since, but good to have this merged to trunk though.