xivapi-py icon indicating copy to clipboard operation
xivapi-py copied to clipboard

Private key shown in loggings

Open DeveloperAnonymous opened this issue 4 years ago • 0 comments

Hello!

Well, I know there is clearly ways to work around this, but it's not really safe in my opinion to print out the private key in the logs.

I know. I can change the logging level to something higher than info for the module, but I just don't think, in any cases, the key should be printed in any type of loggings (maybe debug)

Talking about debug. I don't think a query should be logged at the "info" level but the "debug" INFO:pyxivapi.client:200 from https://xivapi.com/search?language=en&private_key=

DeveloperAnonymous avatar Nov 29 '21 07:11 DeveloperAnonymous