SaintCoinach icon indicating copy to clipboard operation
SaintCoinach copied to clipboard

SaintCoinach.CMD - allexd does not translate all key correctly

Open Akurosia opened this issue 4 years ago • 1 comments

Steps to reproduce:

  1. Open SaintCoinach.CMD
  2. Run lang de (any language would be fine)
  3. run allexd

Example using Action data Actual result: Values for translated keys e.g. ActionCategory are not translated properly (it prefers the specified language from step 2 instead of the file specific languages for Action.en.csv, Action.fr.csv, Action.ja.csv Expected result: All values are translated depending on the file language and in case no specific language can be used e.g. AchievmentTarget.csv it uses the specified language.

Akurosia avatar Jan 27 '22 18:01 Akurosia

this would be a potential fix, but i think it could be done better: https://github.com/Akurosia/SaintCoinach/commit/c66d949edf99fd6d852309147171df82d156e794

Akurosia avatar Feb 03 '22 15:02 Akurosia