flac icon indicating copy to clipboard operation
flac copied to clipboard

flac -t error codes should be more comprehensive

Open smopucilowski opened this issue 5 years ago • 2 comments

Currently files which fail flac -t tests return the same error code: 1.

This arises from issue #192 in which MD5 warnings cannot be differentiated from other failures, subsequently making automation difficult.

smopucilowski avatar Jun 06 '20 02:06 smopucilowski

1️⃣➕ Sounds sensible to me, it would also be very helpful if the approximate timestamp was included in the output, when attempting to debug decoding errors 🙏 (my guess is that the decoder knows which frame failed and could report that, but including a timestamp would provide a more relatable context for a novice like me 🤓 )

flac --test ~/18-INXS\ -\ Elegantly\ Wasted\(Shagsonic\ Remix\).flac

flac 1.4.3
Copyright (C) 2000-2009  Josh Coalson, 2011-2023  Xiph.Org Foundation
flac comes with ABSOLUTELY NO WARRANTY.  This is free software, and you are
welcome to redistribute it under certain conditions.  Type `flac' for details.

18-INXS - Elegantly Wasted(Shagsonic Remix).flac: *** Got error code 0:FLAC__STREAM_DECODER_ERROR_STATUS_LOST_SYNC


18-INXS - Elegantly Wasted(Shagsonic Remix).flac: ERROR during decoding
                                                  state = FLAC__STREAM_DECODER_END_OF_STREAM

((some cases seems related to #487 , where the new stricter decoder error might be triggered by meta-data - being able to distinguish different error sources would be most helpful))

dlehammer avatar Oct 15 '24 20:10 dlehammer

You suggestions have recently already been added in #734.

ktmf01 avatar Oct 16 '24 04:10 ktmf01