fix: warn on custom cache, add option for possibleTypes
when using a custom cache in the render, memory would grow very fast.
run:
yarn
rm -rf node_modules/.cache/ && yarn build -p
clinic doctor -- node ./node_modules/.bin/hops serve
and in a seperate window a few times:
autocannon -c 50 http://localhost:8080/jobs/test
current users are now warned when they pass in a custom cache
instance and we are offering an option to pass in possibleTypes
via options.
in hops 16, we can remove custom caches.
Co-authored-by: Jonas Holland [email protected]
This pull request closes issue # (put the issue number here)
Current state
Changes introduced here
Checklist
- [ ] All commit messages adhere to the appropriate format in order to trigger a correct release
- [ ] All code is written in untranspiled ECMAScript (ES 2017) and is formatted using prettier
- [ ] Necessary unit tests are added in order to ensure correct behavior
- [ ] Documentation has been added
Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of bors delegate+ or bors delegate=[list]).
| Syntax | Description |
|---|---|
| bors merge | Run the test suite and push to master if it passes. Short for "reviewed: looks good." |
| bors merge- | Cancel an r+, r=, merge, or merge= |
| bors try | Run the test suite without pushing to master. |
| bors try- | Cancel a try |
| bors delegate+ | Allow the pull request author to merge their changes. |
| bors delegate=[list] | Allow the listed users to r+ this pull request's changes. |
| bors retry | Run the previous command a second time. |
This is a short collection of opinionated commands. For a full list of the commands read the bors reference.