Marcus Förster
Marcus Förster
@lochmueller shall we also drop `headerComment` ref. https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us/TopLevelObjects/Config.html#confval-config-headercomment
please provide the output of `var_dump($html)` @ [326] & [328]
dont think `/u` is needed @ https://github.com/lochmueller/sourceopt/commit/40c930e267a4dd0f10c7cd0828e0dabc12b75ca9#diff-3cb2417b18f7a3a43576dddc2aeed52f0d925666c81014d687fa7a90aa88824eR345 || https://github.com/lochmueller/sourceopt/blame/main/Classes/Service/CleanHtmlService.php#L328
@kurtkk ; might be defect utf8 char(s) @ $html .. ```patch if (!mb_check_encoding($html, 'UTF-8')) { + mb_substitute_character(0xFFFD); + $html = mb_convert_encoding($html, 'UTF-8', 'UTF-8'); + return str_replace(mb_chr(0xFFFD, 'UTF-8'), '!!', $html); }...
how about the current timestamp after (second line) filename?
would be nice to have additionall tests - no-existing file -> create ``` --- /dev/null +++ b/file.php ``` - existing file -> deleteted ``` --- a/file.php +++ /dev/null ```
> Not really related to this specific change, but this logic block has a bug that was introduced in [d9e9584](https://github.com/alcohol/iso3166/commit/d9e9584f6122263317712d91412fdc3be4565099) fyi/ `strcasecmp` is not used anymore
ok ; but it also fixes `chmod` on running prj. with this patch which might be wrong if c/p before/after the "real" `setup` ``` The following directory structure has been...
fyi/ these are (still) shown via ` `
https://consent.youtube.com/d?continue=https://www.youtube.com/feed/history%3Fcbrd%3D1&gl=DE&m=0&pc=yt&oyh=1&cm=5&hl=en&src=4