UniLua icon indicating copy to clipboard operation
UniLua copied to clipboard

Signed-off-by: kmsmg <[email protected]>

Open kmshenyong opened this issue 1 year ago • 1 comments

kmshenyong avatar Jun 22 '24 02:06 kmshenyong

Hi @kmshenyong,

Thank you for your effort in contributing to the project!

I appreciate the improvements you've made, particularly the unification of indentation in LuaFile.cs. However, I have some concerns regarding other aspects of your pull request:

  • Some files, like Assets/UniLua/Class1.cs, appear to be unnecessary.

  • There are files included that I believe should not be under version control, such as those in the .vs folder and the Assets/UniLua/.vs/UniLua/FileContentIndex/ folder.

  • I'm not quite sure what the intentions are behind some of the changes.

Due to these issues, I am unable to accept the pull request at this time. Please revise your changes accordingly, and feel free to resubmit once these concerns are addressed.

Thank you again for your contributions!

Best regards~

xebecnan avatar Jun 22 '24 11:06 xebecnan