XDA-One icon indicating copy to clipboard operation
XDA-One copied to clipboard

Import of Biohazard's work

Open LalitMaganti opened this issue 10 years ago • 3 comments

This is an import of the excellent work done by @BioHaZard1 on materializing various parts of the app.

My opinion on the changes and this PR:

The Good:

  • The nav drawer looks awesome
  • Thread items also look very cool
  • News items look better too

The Neutral:

  • BLOCKER: post/thread selection states are broken - this needs to be fixed before merge
  • News items could be better - I have tweaked the design from BioHaZard's design
  • Posts - I've made these full bleed tiles to match threads
  • Thread/Post items - I've tweaked various design elements here to make stuff look a bit nicer

The Not So Good

  • Use of dividers in forums - this contradicts MD principles - I've removed the dividers - would appreciate feedback on this
  • Use of non-keyline padding/margins - also removed this since it just makes things inconsistent
  • BLOCKER: Create dialogs - the post and thread dialogs look kinda weird with the change in colour - this should be changed before merge
  • BLOCKER: I hate the press twice to exit - I hate it on every app I encounter this behaviour. I'm strongly in favour of removing this.

Thanks again for the awesome work BioHaZard!

Tagging: @rwestergren, @ddrager

LalitMaganti avatar Apr 23 '15 14:04 LalitMaganti

@tilal6991 I'm wondering what the progress is on this pull request, would love to have these changes merged in!

ddrager avatar Jul 27 '15 13:07 ddrager

I was waiting for @BioHaZard1 to comment but then totally forgot about this stuff. It should still work TBH.

LalitMaganti avatar Jul 30 '15 20:07 LalitMaganti

Yeah sorry about that, completely forgot to comment. I think I've fixed everything you wanted done before the merge though.

BioHaZard1 avatar Jul 30 '15 21:07 BioHaZard1