xarray-tutorial icon indicating copy to clipboard operation
xarray-tutorial copied to clipboard

Updating remote access notebook

Open betolink opened this issue 1 year ago β€’ 6 comments

I'm fixing a few typos in the notebook and adding an explicit way of inspecting the I/O behavior of the different caching strategies implemented in fsspec. I'm also mentioning the impact of chunking in access performance, I think this is now a self contained notebook, I guess we could include the internals of Zarr next.

betolink avatar Jul 17 '24 19:07 betolink

Check out this pull request onΒ  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

🎊 PR Preview fe9141ce31bf1e2611dcc93c3488374895813107 has been successfully built and deployed to https://xarray-contrib-xarray-tutorial-preview-pr-291.surge.sh

πŸ• Build time: 0.011s

πŸ€– By surge-preview

github-actions[bot] avatar Jul 17 '24 19:07 github-actions[bot]

Hi @scottyhq! do you have suggestions on the failing checks? the link that is apparently broken is not really broken and the other is an example not a real link, on the spellcheck bot the fo is a reference to a file-like object.

betolink avatar Jul 18 '24 16:07 betolink

Yeah, the link check unfortunately is finicky and I'm not sure how to exclude specific links. For the spellcheck, you can add fo to the ignore list https://github.com/xarray-contrib/xarray-tutorial/blob/08e762ead64fd598799f135068b15e8edfc8c37e/.github/workflows/qaqc.yaml#L39

Thanks for expanding the notebook, happy to do a full review!

scottyhq avatar Jul 18 '24 16:07 scottyhq

Thanks @scottyhq the PR is ready for review.

betolink avatar Jul 18 '24 19:07 betolink

Thanks for the thorough review @scottyhq! I'll address the suggestions early next week. Also, feel free to edit directly in the notebook!

betolink avatar Aug 01 '24 17:08 betolink