xarray-simlab icon indicating copy to clipboard operation
xarray-simlab copied to clipboard

revisiting snapshots at simulation stages

Open feefladder opened this issue 4 years ago • 0 comments

problem

As mentioned in #164 and #179, the saving of snapshots can be revisited now we have the ability to update a variable inside a process step (#178 and #179). This would make using finalize_step in a model obsolete. However, this is quite a breaking change, and therefore should have a deprecation cycle.

Also, I don't know what can be done before finalize_step is removed.

proposal

  1. issue a warning when the user uses finalize_step in a model, pointing to the documentation #182. and mentioning when the feature is to be deprecated.
  2. actually deprecate the feature, and reduce the entire snapshots system

feefladder avatar Mar 28 '21 14:03 feefladder