commitcoffee icon indicating copy to clipboard operation
commitcoffee copied to clipboard

Consider JavaScript Geolocation API

Open NotBobTheBuilder opened this issue 12 years ago • 9 comments

It would be awesome to have an alternative to the search box which uses window.navigator.geolocation to search for nearby places based on lat/longitude.

Would be particularly useful for mobile users, as it saves typing & gives relevant info. I'll look into it!

NotBobTheBuilder avatar Dec 31 '13 11:12 NotBobTheBuilder

I never had anything in common with this API but sounds really useful. I'm really interested.

xando avatar Dec 31 '13 12:12 xando

There's some pretty good descriptions & examples on mdn

NotBobTheBuilder avatar Dec 31 '13 13:12 NotBobTheBuilder

Oh wait, I know this one ;)

I thought that you meant this https://developers.google.com/maps/documentation/business/geolocation/ though I'm not sure if Google's one is relevant to this case at all.

On Tue, Dec 31, 2013 at 2:48 PM, Jack Wearden [email protected]:

There's some pretty good descriptions & examples on mdnhttps://developer.mozilla.org/en-US/docs/WebAPI/Using_geolocation

— Reply to this email directly or view it on GitHubhttps://github.com/xando/commitcoffee/issues/133#issuecomment-31395195 .

xando avatar Dec 31 '13 14:12 xando

Awesome! I reckon the native one would be best - if we're just using the longitude and latitude then the Google one is probably overkill :)

NotBobTheBuilder avatar Dec 31 '13 14:12 NotBobTheBuilder

If you know how to put those blocks together, go for it. Mobile is not my world, won't be interrupting, much.

On Tue, Dec 31, 2013 at 3:09 PM, Jack Wearden [email protected]:

Awesome! I reckon the native one would be best - if we're just using the longitude and latitude then the Google one is probably overkill :)

— Reply to this email directly or view it on GitHubhttps://github.com/xando/commitcoffee/issues/133#issuecomment-31395795 .

xando avatar Dec 31 '13 14:12 xando

I got a really hacky version running in NotBobTheBuilder@ecac396af5ba8e99b4fa387ab1cb8608b83f643e, but the UX is nasty and the map zooms in too far. Didn't take much work to get going though! I'll tidy it up over the next few days.

NotBobTheBuilder avatar Dec 31 '13 17:12 NotBobTheBuilder

No worries, I will look at this some time in the next year ;)

First short comment we, I don't know how mobile handles it but we need to consider also an use case when user says NO for geolocation.

On Tue, Dec 31, 2013 at 6:15 PM, Jack Wearden [email protected]:

I got a really hacky version running in NotBobTheBuilder@ecac396https://github.com/NotBobTheBuilder/commitcoffee/commit/ecac396af5ba8e99b4fa387ab1cb8608b83f643e, but the UX is nasty and the map zooms in too far. Didn't take much work to get going though! I'll tidy it up over the next few days.

— Reply to this email directly or view it on GitHubhttps://github.com/xando/commitcoffee/issues/133#issuecomment-31402664 .

xando avatar Dec 31 '13 17:12 xando

Guys please.... - stop do anything right now and get drunk. It's New Year's Eve :)

On 31 December 2013 18:24, Sebastian Pawluś [email protected]:

No worries, I will look at this some time in the next year ;)

First short comment we, I don't know how mobile handles it but we need to consider also an use case when user says NO for geolocation.

On Tue, Dec 31, 2013 at 6:15 PM, Jack Wearden [email protected]:

I got a really hacky version running in NotBobTheBuilder@ecac396< https://github.com/NotBobTheBuilder/commitcoffee/commit/ecac396af5ba8e99b4fa387ab1cb8608b83f643e>,

but the UX is nasty and the map zooms in too far. Didn't take much work to get going though! I'll tidy it up over the next few days.

— Reply to this email directly or view it on GitHub< https://github.com/xando/commitcoffee/issues/133#issuecomment-31402664> .

— Reply to this email directly or view it on GitHubhttps://github.com/xando/commitcoffee/issues/133#issuecomment-31403029 .

jqb avatar Dec 31 '13 17:12 jqb

roger that

On Tue, Dec 31, 2013 at 6:26 PM, Kuba Janoszek [email protected]:

Guys please.... - stop do anything right now and get drunk. It's New Year's Eve :)

On 31 December 2013 18:24, Sebastian Pawluś [email protected]:

No worries, I will look at this some time in the next year ;)

First short comment we, I don't know how mobile handles it but we need to consider also an use case when user says NO for geolocation.

On Tue, Dec 31, 2013 at 6:15 PM, Jack Wearden [email protected]:

I got a really hacky version running in NotBobTheBuilder@ecac396<

https://github.com/NotBobTheBuilder/commitcoffee/commit/ecac396af5ba8e99b4fa387ab1cb8608b83f643e>,

but the UX is nasty and the map zooms in too far. Didn't take much work to get going though! I'll tidy it up over the next few days.

— Reply to this email directly or view it on GitHub< https://github.com/xando/commitcoffee/issues/133#issuecomment-31402664> .

— Reply to this email directly or view it on GitHub< https://github.com/xando/commitcoffee/issues/133#issuecomment-31403029> .

— Reply to this email directly or view it on GitHubhttps://github.com/xando/commitcoffee/issues/133#issuecomment-31403111 .

xando avatar Dec 31 '13 17:12 xando