VulkanMod icon indicating copy to clipboard operation
VulkanMod copied to clipboard

[Feature Request] Support for dynamic lighting

Open Danszerlied opened this issue 1 year ago • 1 comments

Describe the request

It'd be very cool if Vulkan mod natively integrates dynamic handheld lighting, as no such mods are compatible with Vulkan mod atm (lambdynlights or ryoamiclights are incompatible)

Danszerlied avatar Oct 05 '24 00:10 Danszerlied

These mods may get support after the 0.5.0 release. You can already find the testing build with FRAPI support in VulkanMod Discord.

Felix14-v2 avatar Oct 05 '24 16:10 Felix14-v2

Dynamic light will probably never be implemented into VulkanMod directly, as it can be easily done externally and would only decrease code readability. Lambdynlights and Ryoamiclights developers need to fix the compatibility issue from their side, as far as I know.

NXTler avatar Oct 27 '24 10:10 NXTler

~~This can be closed.~~

NXTler avatar Oct 27 '24 10:10 NXTler

Dynamic light will probably never be implemented into VulkanMod directly, as it can be easily done externally and would only decrease code readability. Lambdynlights and Ryoamiclights developers need to fix the compatibility issue from their side, we can't do anything.

LambDynamicLights uses LevelRender.getLightColor(BlockAndTintGetter, BlockState, BlockPos) as its injection point, and with several versions of similar rendering mods not requiring specific compatibility code anymore, I personally would rather avoid adding yet more fragile injections in my own mod.

Relevant issue on LambDynamicLights' side: LambdAurora/LambDynamicLights#238.

LambdAurora avatar Oct 28 '24 19:10 LambdAurora

Fixed by 349de86

xCollateral avatar Nov 27 '24 21:11 xCollateral