Game Path should be removed from the setup GUI

[Cokemonkey11]

As discussed in #51, instead of revamping the feature for detecting wc3 game path, we should instead delete the feature from wurstsetup.

This has some benefits:

1. Consolidates the set of places that a wurst user encounters the idea of a game path
2. Reduces support burden as blizzard keeps fucking the detectable game path
3. Simplifies the workflow for creating and updating projects

I am happy to do this work if I get a +1 from a maintainer @peq @Frotty .

My approach to deleting this feature is just find gamePathTF (only present in MainWindow.kt), deleting it, deleting dead code that comes out of doing so, and then testing to verify that it had the expected effect.

• Double-check also that the text "Game path" is eradicated
• Double-check that the [...] icon and its click handler are also properly deleted

[Frotty]

Thanks for creating the issue. Perhaps removing it from setup and then adding handling to the compiler to open a file browser if wc3 dir cannot be detected would be best. Autodetection finds default install locations, but if it's located in a custom directory (because of previous classic installation e.g.) right now the run commands simply fail without good user feedback.

[Cokemonkey11]

@Frotty thanks for response.

As above, I'm happy to do the work to remove this from setup. However, your comments above made me think that perhaps the compiler feature is needed first to keep the feeling of "no feature is lost".

To be clear: will you approve a PR that removes this from setup, even if I don't have a follow-up for compiler?

Cheers

[Frotty]

To be clear: will you approve a PR that removes this from setup, even if I don't have a follow-up for compiler?

No cuz then there is no gui possibility to change the path

[Cokemonkey11]

@Frotty okay - I don't plan to make this contribution on compiler. Shall we reopen #51 instead to do some basic maintenance on the existing feature?