WunderTools icon indicating copy to clipboard operation
WunderTools copied to clipboard

Fix/aa minor fixes after lando update

Open aaleksu opened this issue 7 years ago • 3 comments

fixed indentation in .lando.yml fixed settings.lando.php: getting database settings from lando info env (lando_info is a list, not a hash - taking service info by servie key does not make any sense)

aaleksu avatar Mar 27 '19 07:03 aaleksu

@aaleksu , could you please create a separate PR for indentation fix? Then we can merge it in and discuss about other changes further here.

tormi avatar Mar 27 '19 08:03 tormi

+1 for indentation fix, thanks!

settings.lando.php comes from here: wunderio/drupal-project#22, doesn't it work for you?

No, it does not work. I get empty database settings when I debug $databases variable in settings.php. And it happens because $lando_info does not have key database. So, it just puts NULLs into all the database values.

aaleksu avatar Mar 27 '19 08:03 aaleksu

@aaleksu , could you please create a separate PR for indentation fix? Then we can merge it in and discuss about other changes further here.

The thing is that app will start successfully, but you won't get project running, because Drupal will not be able to connect to database (because of wrong (null) credentials).

aaleksu avatar Mar 27 '19 08:03 aaleksu