graphql-go-tools icon indicating copy to clipboard operation
graphql-go-tools copied to clipboard
verified publisher icon wundergraph

fix: update websocket handlers to eliminate goroutine leaks (#796)

Open BenjaminYong opened this issue 1 year ago • 1 comments

Hi team,

Please see the suggested fixes to address the issue I raised: https://github.com/wundergraph/graphql-go-tools/issues/796

After this change, the websocket handlers and their goroutines are closing as expected. As a result, my memory usage is much more lower and no longer leaking. image

Thanks, Benny

BenjaminYong avatar May 13 '24 07:05 BenjaminYong

Please fix CI. ;-)

jensneuse avatar May 14 '24 09:05 jensneuse

@BenjaminYong friendly ping 😄

StarpTech avatar May 28 '24 09:05 StarpTech

Sorry guys, been struggling to reproduce, though I'm on darwin/arm64. Mine doesn't fail like the CI does, any tips? image

BenjaminYong avatar May 28 '24 23:05 BenjaminYong

@jensneuse @devsergiy @StarpTech CI is passing.

Aenimus avatar Jun 04 '24 19:06 Aenimus

@BenjaminYong added in tag v1.67.3

devsergiy avatar Jun 12 '24 19:06 devsergiy