api-manager icon indicating copy to clipboard operation
api-manager copied to clipboard

API creation and attachment not disabled in api policies tab for revision

Open tharindu1st opened this issue 11 months ago • 20 comments

Description

No response

Steps to Reproduce

1.create api with policy attachment. 2. Create revision 3. Goto Revision and select policies tab 4. you'll able to attach select policies.

Version

4.4.0

Environment Details (with versions)

No response

tharindu1st avatar Mar 07 '25 10:03 tharindu1st

Revisions are read-only. Since the Save button is disabled, no actual harm is done, but we should also disable policy editing on the revision page.

Image

chamilaadhi avatar Sep 15 '25 10:09 chamilaadhi

hi @chamilaadhi I’d like to reserve this issue. I can investigate and fix the policy attachment behavior in API revisions to ensure policies are handled consistently in version 4.4.0.

Iduranga-Uwanpriya avatar Sep 23 '25 01:09 Iduranga-Uwanpriya

@Iduranga-Uwanpriya i have assigned this to you.

chamilaadhi avatar Sep 25 '25 09:09 chamilaadhi

Thank you so much Sir i will send a PR soon

Iduranga-Uwanpriya avatar Sep 25 '25 16:09 Iduranga-Uwanpriya

Hi @Iduranga-Uwanpriya, is there any update on the progress? In case you are unable to work on this issue at the moment due to any reason, please let us know at the earliest. Thanks!

pavinduLakshan avatar Oct 06 '25 05:10 pavinduLakshan

hello @pavinduLakshan so sorry for not being so active on this issue since my final year of IIT has started i have to submit my PPRS on this 10th of October i'm having a really busy and stressful weeks going on so i will work on this ASAP

Iduranga-Uwanpriya avatar Oct 06 '25 05:10 Iduranga-Uwanpriya

Hello @pavinduLakshan Does the Code lives on carbon-apimgt?

Iduranga-Uwanpriya avatar Oct 06 '25 05:10 Iduranga-Uwanpriya

@chamilaadhi @Iduranga-Uwanpriya I hope you are doing well. I have reviewed this issue and would like to respectfully request to be assigned to it. I am eager to contribute and will ensure that my work aligns with the project’s guidelines and standards. can u assign me this issue pls

Thank you very much for considering my request. 🙏

ProgrammingPirates avatar Oct 06 '25 13:10 ProgrammingPirates

Hi @Iduranga-Uwanpriya, the issue is related to the UI hence the code is in apim-apps repository[1]. You can refer article [2] to get an understanding about the development.

[1] https://github.com/wso2/apim-apps [2] https://medium.com/@tharika/how-to-contribute-to-wso2-api-manager-65d96fa9665c

tharikaGitHub avatar Oct 07 '25 07:10 tharikaGitHub

Hey @tharikaGitHub i am having troubles when stepping the wso2 api manager do we need a nx server for run this

Iduranga-Uwanpriya avatar Oct 14 '25 11:10 Iduranga-Uwanpriya

Hi @Iduranga-Uwanpriya no, you can set APIM up on a normal VM. You can refer [1] for installation prerequisites if that is what you are looking for. Have you referred article [2]?

[1] https://apim.docs.wso2.com/en/latest/install-and-setup/install/installation-prerequisites/ [2] https://medium.com/@tharika/how-to-contribute-to-wso2-api-manager-65d96fa9665c

tharikaGitHub avatar Oct 14 '25 12:10 tharikaGitHub

@tharikaGitHub yes i cleared all my issues now thank you for the assistance

Iduranga-Uwanpriya avatar Oct 14 '25 12:10 Iduranga-Uwanpriya

HI @chamilaadhi @tharikaGitHub i made my first pull request please check and let me know Thank you Link-https://github.com/wso2/apim-apps/pull/1191

Iduranga-Uwanpriya avatar Oct 15 '25 09:10 Iduranga-Uwanpriya

hi @pavinduLakshan can i have a comment on the PR?

Iduranga-Uwanpriya avatar Oct 16 '25 06:10 Iduranga-Uwanpriya

hi @pavinduLakshan can i have a comment on the PR?

Hi @Iduranga-Uwanpriya, let's get an approval from the API manager team who owns the apim-apps codebase.

cc: @tharikaGitHub @chamilaadhi

pavinduLakshan avatar Oct 16 '25 06:10 pavinduLakshan

Thank you so much @pavinduLakshan

Iduranga-Uwanpriya avatar Oct 16 '25 06:10 Iduranga-Uwanpriya

hi @chamilaadhi @tharikaGitHub is there any updates 👀

Iduranga-Uwanpriya avatar Oct 19 '25 06:10 Iduranga-Uwanpriya

Hi @Iduranga-Uwanpriya we will review your PR and let you know if anything needs to change. Thanks for your contribution.

tharikaGitHub avatar Oct 20 '25 05:10 tharikaGitHub

Adding the new PR here for reference - https://github.com/wso2/apim-apps/pull/1214

tharikaGitHub avatar Oct 31 '25 09:10 tharikaGitHub

Hi @Iduranga-Uwanpriya I have added some comments to your PR. The functionality works fine but shall we check if the pointed out changes are necessary?

tharikaGitHub avatar Oct 31 '25 15:10 tharikaGitHub