WRF icon indicating copy to clipboard operation
WRF copied to clipboard

[Chem] Wrong unit or comment in chem/VPRM fluxes

Open lpilz opened this issue 3 years ago • 5 comments

In the following line, either the unit conversion factor is too small by 3 orders of magnitude or the comment concerning the unit conversion is wrong.

mmol/m^2/s = 1e6 mmol/km^2/s = 1e3 mol/km^2/s = 3.6e6 mol/km^2/h

https://github.com/wrf-model/WRF/blob/f34b11dbb89c002c5c0dca1195aab35daeed7349/chem/module_ghg_fluxes.F#L131

lpilz avatar Sep 22 '22 19:09 lpilz

@jordanschnell Can you check? Thanks!

weiwangncar avatar Sep 22 '22 19:09 weiwangncar

@weiwangncar - Confirming with a frequent user of this module, will update

jordanschnell avatar Sep 28 '22 18:09 jordanschnell

@jordanschnell Just wanted to check back if there are any updates

lpilz avatar Dec 21 '22 17:12 lpilz

Hi All, here the comment is wrong, the actual unit should be micro-mole m-2 s-1, as per reported in Mahadevan et al., 2008. I guess the original code developer was in haste, and since there are no Greek letters in Fortran...

See. Table 2.

https://agupubs.onlinelibrary.wiley.com/doi/10.1029/2006GB002735

michal-galkowski avatar Apr 24 '24 10:04 michal-galkowski

In that case, I would suggest changing this to ! For unit conversion from umol/m^2/s to mol/km2/hr

lpilz avatar May 02 '24 09:05 lpilz