wrf-model
NoahMP bug fix
A few bug fixes for NoahMP
TYPE: bug fix
KEYWORDS: two stream inout variable, soil ice in snow combine, water variable unit
SOURCE: Cenlin He (NCAR) with report from CWB/Taiwan
DESCRIPTION OF CHANGES: A few bug fixes for NoahMP:
- Change a few "out" only variables in TWOSTREAM noahmp subroutine to "inout";
- Change the unit for 3 accumulated noahmp water flux variables in comments and registry;
- Change the soil ice treatment in snow combine subroutine to conserve water;
LIST OF MODIFIED FILES: list of changed files M Registry/registry.noahmp M phys/noahmp
TESTS CONDUCTED:
- The bug fixes have been tested for NoahMP run over the U.S. for an entire year.
- Reg tests have passed.
The Jenkins tests have passed:
Test Type | Expected | Received | Failed = = = = = = = = = = = = = = = = = = = = = = = = = = = = Number of Tests : 23 24 Number of Builds : 60 58 Number of Simulations : 158 156 0 Number of Comparisons : 95 92 0
Failed Simulations are:
None
Which comparisons are not bit-for-bit:
None
@cenlinhe Would you like to make this change available sooner? That would mean 4.4.2.
When will this PR be merged to develop or release-v4.4.2 branch? Recently, two other NoahMP bugs have been identified and I would like to create another PR for those bug fixes based on the updated develop or release-v4.4.2 branch with the current PR bug fix included. Thanks!
@dudhia Can you check this PR and approve if it is OK so that Cenlin can move to his next change?
Those are just changing the hard-coded "4" soil layers to "nsoil". By default, NoahMP uses 4 soil layers, so this change is no-answer change. However, this gives more flexibility for users to change nsoil in the future. Otherwise, users need to manually change the hard-coded "4" soil layer in those code files.
@cenlinhe Can you clarify what 'snow combine subroutine' is? This is in your description of change #3.
It is this subroutine "COMBINE" in module_sf_noahmplsm.F. I have included this in the above description.