float icon indicating copy to clipboard operation
float copied to clipboard

Method as.matrix

Open david-cortes opened this issue 5 years ago • 1 comments

The method as.matrix will convert a float32 vector into a float32 matrix.

However, as.matrix as used in other packages is meant to return a matrix object, which allows creating libraries that accept arbitrary objects from other packages without having to add them as dependencies - that is, one can create a library with a function that takes an input X, call as.matrix on it, and then pass it to a function that expects a matrix object, with the X potentially being a data.table, dgCMatrix, etc. (without adding dependencies on data.table or Matrix).

Would be nice if this package could follow this logic too, perhaps adding a different function as.float_matrix or the like that would do what as.matrix.float32 currently does.

david-cortes avatar Jan 10 '21 11:01 david-cortes

You make a good point. I think it makes sense to change it as you suggest. I will try to get to it in the next few days, but PR's welcome.

wrathematics avatar Jan 10 '21 15:01 wrathematics