GradleRIO icon indicating copy to clipboard operation
GradleRIO copied to clipboard

Versioning should be done on Git tag

Open Daltz333 opened this issue 5 years ago • 7 comments

Do not hardcode, but use git tags

Daltz333 avatar Oct 09 '20 01:10 Daltz333

I think the version might need to be hardcoded (or at least accessible from plugin code) for release. Unless maybe we hardcode to gradle.properties (#429 ) and publish in CI.

Starlight220 avatar Oct 09 '20 05:10 Starlight220

@ThadHouse do you think that it's realistic/practical to publish via CI that hardcodes the latest git tag to gradle.properties?

Starlight220 avatar Oct 18 '20 06:10 Starlight220

Hasn't this been handled by #444?

Starlight220 avatar Nov 21 '20 21:11 Starlight220

yes

Daltz333 avatar Nov 21 '20 22:11 Daltz333

Not yet. We still need to make a commit to update the version manually.

https://github.com/wpilibsuite/GradleRIO/blob/master/gradle.properties#L1

AustinShalit avatar Nov 21 '20 22:11 AustinShalit

A commit editing gradle.properties will be needed anyway. The trick is that we might be able to have the commit done by GH Actions, though then the tag will be on the prior commit. We can have a manually-triggered workflow that commits the version change and tags that commit.

Starlight220 avatar Nov 22 '20 07:11 Starlight220

We can get the version number from the latest tag so bumping the gradle.properties manually or automatically isn't required.

All of the tools and allwpilib do this already.

prateekma avatar Nov 22 '20 14:11 prateekma