Versioning should be done on Git tag
Do not hardcode, but use git tags
I think the version might need to be hardcoded (or at least accessible from plugin code) for release. Unless maybe we hardcode to gradle.properties (#429 ) and publish in CI.
@ThadHouse do you think that it's realistic/practical to publish via CI that hardcodes the latest git tag to gradle.properties?
Hasn't this been handled by #444?
yes
Not yet. We still need to make a commit to update the version manually.
https://github.com/wpilibsuite/GradleRIO/blob/master/gradle.properties#L1
A commit editing gradle.properties will be needed anyway. The trick is that we might be able to have the commit done by GH Actions, though then the tag will be on the prior commit.
We can have a manually-triggered workflow that commits the version change and tags that commit.
We can get the version number from the latest tag so bumping the gradle.properties manually or automatically isn't required.
All of the tools and allwpilib do this already.