extension-command icon indicating copy to clipboard operation
extension-command copied to clipboard
verified publisher icon wp-cli

Fix: correctly deactivate network activated plugin before uninstall.

Open NielsdeBlaauw opened this issue 3 years ago • 3 comments

When uninstalling a network activated plugin, the network tag is now added to correctly deactivate the plugin before removal.

Fixes #312

NielsdeBlaauw avatar Jun 02 '22 13:06 NielsdeBlaauw

@NielsdeBlaauw thank you for your contribution! It looks good to me, however the functional tests are failing. Can you please look into it? Let me know if you need any help, thanks!

Sidsector9 avatar Jun 06 '22 07:06 Sidsector9

@Sidsector9 thanks, I've updated the changeset to fix the output for results reporting. Cheers.

NielsdeBlaauw avatar Jun 06 '22 10:06 NielsdeBlaauw

The code looks good. It should have a test to cover this specific usage with a multisite. I recommend taking a look here to write tests with a multisite setup.

If you need help give a shout.

janw-me avatar Jun 06 '22 13:06 janw-me

Proceeding with https://github.com/wp-cli/wp-cli/issues/5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/f9aa4f759c7d57ff2663d07766241692 in case this PR is auto-closed or broken in some way.

danielbachhuber avatar Nov 18 '22 16:11 danielbachhuber