extension-command icon indicating copy to clipboard operation
extension-command copied to clipboard

Running wp plugin update --all that results in an update package not being available results in reported successful update

Open TwistedTabby opened this issue 6 years ago • 0 comments

Bug Report

Describe the current, buggy behavior

Specific example for reproduction: I have js_composer plugin installed via a theme... this means I have to go through a separate process to actually get the update for the plugin.

When I run wp plugin update --all the only line response for the js_composer plugin is Warning: Update package not available. AND then it's listed in the table as Updated.

Enabling Maintenance mode...
... other plugins being updated ...
Warning: Update package not available.
Disabling Maintenance mode...
+-------------+-------------+-------------+---------+
| name        | old_version | new_version | status  |
+-------------+-------------+-------------+---------+
| js_composer | 6.0.5       | 6.1         | Updated |
+-------------+-------------+-------------+---------+
Success: Updated 14 of 14 plugins.

when I run wp plugin update js_composer I get the error.

wp plugin update js_composer
Enabling Maintenance mode...
Warning: Update package not available.
Disabling Maintenance mode...
+-------------+-------------+-------------+--------+
| name        | old_version | new_version | status |
+-------------+-------------+-------------+--------+
| js_composer | 6.0.5       | 6.1         | Error  |
+-------------+-------------+-------------+--------+
Error: No plugins updated.

Describe how other contributors can replicate this bug

  • have a premium plugin that requires licensing to get updates (some examples are: ithemes security pro, WPBakery Page Builder (js_composer))

Describe what you would expect as the correct outcome

Getting the error would be great... since it wasn't actually updated.

Let us know what environment you are running this on

wp --info
OS:	Linux 5.0.0-37-generic #40~18.04.1-Ubuntu SMP Thu Nov 14 12:06:39 UTC 2019 x86_64
Shell:	/bin/bash
PHP binary:	/usr/bin/php7.3
PHP version:	7.3.12-1+ubuntu18.04.1+deb.sury.org+1
php.ini used:	/etc/php/7.3/cli/php.ini
WP-CLI root dir:	phar://wp-cli.phar/vendor/wp-cli/wp-cli
WP-CLI vendor dir:	phar://wp-cli.phar/vendor
WP_CLI phar path:	/mnt/volume-01/clones/<redacted>
WP-CLI packages dir:	/home/<redacted>/.wp-cli/packages/
WP-CLI global config:
WP-CLI project config:
WP-CLI version:	2.4.0

Provide a possible solution

Provide additional context/Screenshots

TwistedTabby avatar Dec 19 '19 15:12 TwistedTabby