extension-command icon indicating copy to clipboard operation
extension-command copied to clipboard
verified publisher icon wp-cli

Added condition to list broken themes on wp theme list

Open achyuthajoy opened this issue 6 years ago • 3 comments

Fix for #152

Enabled option to show broken themes

achyuthajoy avatar Mar 03 '19 16:03 achyuthajoy

Thanks for the PR, @achyuthajoy. Two things are needed still for this:

  1. Please add a behat test that confirms that a broken theme is indeed shown.
  2. Let's discuss how to visually denote a broken theme. Should it just be part of the normal list, or should be display it in a special way to let the user know it is broken?

schlessera avatar Mar 04 '19 17:03 schlessera

Sure @schlessera, I'll add the test and look for possible solutions to display the broken themes

achyuthajoy avatar Mar 05 '19 16:03 achyuthajoy

@schlessera I've added the tests. For point (2), I think we can add a message after the table informing users of broken themes?

Sidsector9 avatar May 25 '22 06:05 Sidsector9

Proceeding with https://github.com/wp-cli/wp-cli/issues/5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/c90d59dc7e64952cc636d305d313597e in case this PR is auto-closed or broken in some way.

danielbachhuber avatar Nov 18 '22 16:11 danielbachhuber