db-command icon indicating copy to clipboard operation
db-command copied to clipboard

Feature Request: Return number of rows affected by update/delete queries.

Open crazyjaco opened this issue 7 years ago • 4 comments

Hello.

I recently used WP-CLI to run some SQL queries. After they run, I only got a success or failure message. If it was a success, I did not receive any feedback about how many rows were affected. Running the query directly in MySQL, it lets me know how many rows were affected.

It was would nice to have that metric returned or optionally returned.

Not sure if that would be part of the normal output or added as a new switch.

Thank you for your time.

crazyjaco avatar Oct 22 '18 18:10 crazyjaco

Yes, that makes sense and I think it would be a worthwhile improvement.

Would you be up for creating a pull request for this, @crazyjaco ?

schlessera avatar Oct 23 '18 15:10 schlessera

I would be interested in that, but I don't have a lot of time to spare in the next week or two. I can look at it after that I think. Would that be alright?

crazyjaco avatar Oct 24 '18 14:10 crazyjaco

@crazyjaco Yes, sure. Feel free to ping me when you started to work on it and get stuck!

schlessera avatar Oct 24 '18 15:10 schlessera

I could've used this today in connection with a large DELETE operation https://stackoverflow.com/questions/1318972/deleting-millions-of-rows-in-mysql to do something like

rows_affected = 0
do {
 rows_affected = do_query(
   "DELETE FROM messages WHERE created < DATE_SUB(NOW(),INTERVAL 3 MONTH)
   LIMIT 10000"
 )
} while rows_affected > 0

But can't get "rows affected" from wp db query.

lkraav avatar Feb 21 '22 09:02 lkraav