config-command icon indicating copy to clipboard operation
config-command copied to clipboard

Replace boolean value of config variables to literal string when showing to the user

Open imrraaj opened this issue 1 year ago • 3 comments

This pull request fixes following issue

  • #165

I refactored the code to return the string representation of a boolean value (i.e., 'true' or 'false'), which is easier to display to the user. Previously, when the variable's value was true, it would render as '1', and blank when false. Using strings allows us to provide clearer guidance to the user regarding which value is true and which is false.

imrraaj avatar Jun 18 '24 11:06 imrraaj

Can I get a review on this PR? @danielbachhuber

imrraaj avatar Jul 02 '24 05:07 imrraaj

@imrraaj, can this be tested with the behat feature tests to cover the various types of truthy/falsy values that might be used in wp-config?

pwtyler avatar Nov 01 '24 18:11 pwtyler

@imrraaj I think this can potentially break scripts that already rely on the current behavior.

We could put this behind a flag and have the flag default to using this if interactive and not using this if non-interactive.

I'll need to check what prior behavior we have that is similar to this so we can stay consistent...

schlessera avatar Feb 05 '25 14:02 schlessera