gitpay icon indicating copy to clipboard operation
gitpay copied to clipboard

Convert React component to functional component

Open alexanmtz opened this issue 2 years ago • 8 comments

Change the file './frontend/src/components/profile/skill.js' to a functional react component.

alexanmtz avatar Feb 07 '24 19:02 alexanmtz

@alexanmtz please assign me this issue👨‍💻

Asin-Junior-Honore avatar Feb 11 '24 09:02 Asin-Junior-Honore

Hey @Asin-Junior-Honore, we have this PR: https://github.com/worknenjoy/gitpay/pull/1058; you can continue from there; please check it out and test locally. You need to open the user skill page: https://gitpay.me/#/profile/user-account/skills

Let me know if you need any help

alexanmtz avatar Feb 11 '24 13:02 alexanmtz

@alexanmtz when i test the site in my Browser locally it displays the landing page very well and clearly but when i try to login i get this message👇 although my internet is working fine Screenshot (1)

Asin-Junior-Honore avatar Feb 11 '24 22:02 Asin-Junior-Honore

@Asin-Junior-Honore, the local integration to log in via Github is not enabled by default, so please create an account with an e-mail and a password. The activation to activate your account locally is usually from e-mail, but locally, there's no mail server, so you will be able to activate your account by copying the activation link on your local server log.

alexanmtz avatar Feb 12 '24 08:02 alexanmtz

@alexanmtz i am really sorry for the late response but could you please give more context on the required solution please🙏

Asin-Junior-Honore avatar Feb 20 '24 14:02 Asin-Junior-Honore

@Asin-Junior-Honore register with a regular account using e-mail instead of Github locally, then go to your terminal when you ran the server and you will see the email content for account activation there, then you can copy and paste the link, then go to your skills section on: http://localhost:8082/#/profile/user-account/skills locally and you should open the page with any errors :-)

alexanmtz avatar Feb 20 '24 15:02 alexanmtz

@alexanmtz I followed your instructions but am still not getting any activation details in my terminal besides I am always getting error in my terminal whenever I try npm I

Asin-Junior-Honore avatar Feb 20 '24 23:02 Asin-Junior-Honore

Which error are you facing? Have you followed the documentation on README to make the proper setup?

-- Alexandre Magno Teles Zimerer Software Engineer https://alexandremagno.net/ github.com/alexanmtz @alexanmtz

On Wed, 21 Feb 2024 at 00.56, Asin-Honore @.***> wrote:

@alexanmtz https://github.com/alexanmtz I followed your instructions but am still not getting any activation details in my terminal besides I am always getting error in my terminal whenever I try npm I

— Reply to this email directly, view it on GitHub https://github.com/worknenjoy/gitpay/issues/1057#issuecomment-1955410548, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAVWCGLJYMUQMSYD7GI6OTYUUZZLAVCNFSM6AAAAABC6L7GI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJVGQYTANJUHA . You are receiving this because you were mentioned.Message ID: @.***>

alexanmtz avatar Feb 21 '24 11:02 alexanmtz

@alexanmtz Can you please assign me to this issue ?

Dheeraj4103 avatar Aug 04 '24 12:08 Dheeraj4103

Yes @Dheeraj4103 , feel free to send a PR with your solution 👌

alexanmtz avatar Aug 08 '24 14:08 alexanmtz

Thanks @alexanmtz , I will start working on it.

Dheeraj4103 avatar Aug 08 '24 15:08 Dheeraj4103

Hey @alexanmtz , there are lot of libraries that are deprecated, even if I use docker to build project both frontend and backend fails.

Dheeraj4103 avatar Aug 09 '24 14:08 Dheeraj4103

@Dheeraj4103 I guess we need to fix docker-compose to make it work properly: https://github.com/worknenjoy/gitpay/issues/1010

And for run the project without docker and install with decrecated dependencies you need to run: npm i --legacy-peer-deps

alexanmtz avatar Aug 11 '24 11:08 alexanmtz

hey @alexanmtz, some packages require node v12 but some require version > v14, even after using command given by I'm not able to setup project

Dheeraj4103 avatar Aug 11 '24 13:08 Dheeraj4103

@Dheeraj4103 You need to use Node v17 to be able to run the backend server, and for the fron-end you can run the project with npm i --legacy-peer-deps

alexanmtz avatar Aug 11 '24 13:08 alexanmtz

hey @alexanmtz I tried what you said but it didn't work.

Dheeraj4103 avatar Aug 11 '24 14:08 Dheeraj4103

You need to update package.json because many packages are deprecated and suggested to use alternative packages like image

Dheeraj4103 avatar Aug 11 '24 14:08 Dheeraj4103

@Dheeraj4103, have you updated and made it work? If that's the case, you can send a PR with the fix

alexanmtz avatar Aug 14 '24 10:08 alexanmtz

@Dheeraj4103 have you tried this? https://stackoverflow.com/questions/65594119/node-sass-usage-is-deprecated-and-will-be-removed-in-a-future-major-version

And just to make sure, your issue is on the Node server right?

alexanmtz avatar Aug 14 '24 10:08 alexanmtz

Hey @alexanmtz I have updated package.json for backend and it is working fine now, Thanks for help. Frontend is also working fine But I have tried seeding the database but it doesn't work. image

Dheeraj4103 avatar Aug 15 '24 05:08 Dheeraj4103

That's a great progress @Dheeraj4103, and it's really weird the seed having this output.

Have you ran the migrations successfully with npm run migrate? You need to run this one first

And what's your OS? Windows? Linux? Mac?

alexanmtz avatar Aug 16 '24 08:08 alexanmtz

Hey @alexanmtz, I have ran the migrations and it was successful, but I encountered an issue while seeding data, My OS is Windows

Dheeraj4103 avatar Aug 16 '24 08:08 Dheeraj4103

@Dheeraj4103 please check our README file for running the seed on Windows: https://github.com/worknenjoy/gitpay?tab=readme-ov-file#for-windows-users

alexanmtz avatar Aug 16 '24 11:08 alexanmtz

hey @alexanmtz I have set up project. But some data is not seeded, I think I need to Setup the project again.

Should I create a seperate PR for updated package.json

Dheeraj4103 avatar Aug 17 '24 13:08 Dheeraj4103

Hey @alexanmtz, I have successfully set up project, and everything is working fine, I was able to Signup and login. image

But there are few test cases that are failing, which are related to Task image

Dheeraj4103 avatar Aug 18 '24 05:08 Dheeraj4103

Hey @alexanmtz, I have successfully converted class component to functional component in skill.js file. Please have a look at the PR and let me know if there is any issue.

Dheeraj4103 avatar Aug 18 '24 05:08 Dheeraj4103

Hey @alexanmtz, I have successfully set up project, and everything is working fine, I was able to Signup and login. !

But there are few test cases that are failing, which are related to Task image

thats great @Dheeraj4103 , I guess the tests are failing because you need to run the migration for tests too, so have you tried npm run migrate-test?

alexanmtz avatar Aug 19 '24 13:08 alexanmtz

Hey @alexanmtz, I have successfully set up project, and everything is working fine, I was able to Signup and login. ! But there are few test cases that are failing, which are related to Task image

thats great @Dheeraj4103 , I guess the tests are failing because you need to run the migration for tests too, so have you tried npm run migrate-test? yes I have tried this but it's still failing. And please have a look at the PR that I have created.

Dheeraj4103 avatar Aug 19 '24 14:08 Dheeraj4103

Yeah @Dheeraj4103 I will start to review your PR :)

alexanmtz avatar Aug 19 '24 14:08 alexanmtz

Your PR was merged and already in production @Dheeraj4103 , thanks for the contribution, and feel free to start work in any other issue you're interested

alexanmtz avatar Aug 23 '24 12:08 alexanmtz