Workbench Remove Icon Library

Closes #808

My strategy isn't fool-proof: I just greped for "icon", and removed everything related to the Icon Library. There might still be remains of it that I missed, but I believe there's no way of accessing it anymore.

Nov 18 '23 17:11 gregorni

Should that happen in a separate PR or in this one?

Nov 19 '23 10:11 gregorni

An other one makes things simpler and we can make this one depend on it.

Nov 19 '23 11:11 sonnyp

Note; in this PR you can also remove the "icon-development-Kit" module.

Nov 24 '23 22:11 sonnyp

Note; in this PR you can also remove the "icon-development-Kit" module.

I tried doing that, but then the Image demo breaks, and some of the icons in the UI go missing. I think it might be easier to keep the development kit than hand-picking, saving, and including the specific ones we need.

Nov 24 '23 23:11 gregorni

For icons we use in Workbench UI, we should add them to src/icons

For demos, we should use icons provided in org.gnome.Platform only

Nov 24 '23 23:11 sonnyp

That sounds like work for a separate PR

Nov 24 '23 23:11 gregorni

What would be the difference between the Image and the Icons demo?

Dec 04 '23 18:12 gregorni

Closing in favor of https://github.com/workbenchdev/Workbench/pull/932

Apr 15 '24 23:04 sonnyp