release-toolkit icon indicating copy to clipboard operation
release-toolkit copied to clipboard

Investigate `create_pull_request` failing silently

Open mokagio opened this issue 2 years ago • 1 comments

This build passed but no PR was created.

image

mokagio avatar Jan 31 '24 01:01 mokagio

FYI: From a quick look at the fastlane source code, seems like the CreatePullRequestAction is implemented in such a way that it will return the PR url when successful… and [nil in case of errors] (as opposed to exiting with non-zero).

Which means it's assumed that one is supposed to check the return value of create_pull_request to check if it succeeded or not.

AliSoftware avatar Feb 28 '24 15:02 AliSoftware