WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Reader: Add accessibility labels to Reader tags feed

Open wargcm opened this issue 1 year ago • 3 comments

Fixes #23137

Description

  • Adds accessibility labels to the "Your Tags" feed
  • Reuses accessibility labels/hints from ReaderPostCardCell

Testing

To test:

  • Launch Jetpack and login
  • Navigate to the "Your Tags" feed
  • If you're using the simulator: Open the Accessibility Inspector
  • If you're using a device: Enable VoiceOver
  • Go through the accessibility labels and 🔎 verify each is set and voiced correctly

Regression Notes

  1. Potential unintended areas of impact Should be none.

  2. What I did to test those areas of impact (or what existing automated tests I relied on) N/A

  3. What automated tests I added (or what prevented me from doing so) N/A

PR submission checklist:

  • [x] I have completed the Regression Notes.
  • [x] I have considered adding unit tests for my changes.
  • [x] I have considered adding accessibility improvements for my changes.
  • [x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

wargcm avatar May 02 '24 00:05 wargcm

1 Warning
:warning: View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by :no_entry_sign: Danger

dangermattic avatar May 02 '24 00:05 dangermattic

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23138-20040ea
Version24.8
Bundle IDcom.jetpack.alpha
Commit20040eab75cbe2a254c33d770cf42e2308ca2474
App Center Buildjetpack-installable-builds #8807
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar May 02 '24 01:05 wpmobilebot

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23138-20040ea
Version24.8
Bundle IDorg.wordpress.alpha
Commit20040eab75cbe2a254c33d770cf42e2308ca2474
App Center BuildWPiOS - One-Offs #9761
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar May 02 '24 01:05 wpmobilebot