WordPress-iOS icon indicating copy to clipboard operation
WordPress-iOS copied to clipboard

Offline Mode: Remove status label from post cell

Open momo-ozawa opened this issue 1 year ago • 5 comments

Part of #22578

Description

  • Removes the status label from the post cell
  • Adds "sticky" label to the badges label
Idle Syncing Offline changes Failed

How to test

  • Posts list: Verify the status labels aren't displayed for any of the sync states
  • Dashboard drafts/scheduled posts card: Verify status labels aren't displayed

Regression Notes

  1. Potential unintended areas of impact n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on) n/a

  3. What automated tests I added (or what prevented me from doing so) n/a

PR submission checklist:

  • [ ] I have completed the Regression Notes.
  • [ ] I have considered adding unit tests for my changes.
  • [ ] I have considered adding accessibility improvements for my changes.
  • [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • [ ] WordPress.com sites and self-hosted Jetpack sites.
  • [ ] Portrait and landscape orientations.
  • [ ] Light and dark modes.
  • [ ] Fonts: Larger, smaller and bold text.
  • [ ] High contrast.
  • [ ] VoiceOver.
  • [ ] Languages with large words or with letters/accents not frequently used in English.
  • [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • [ ] iPhone and iPad.
  • [ ] Multi-tasking: Split view and Slide over. (iPad)

momo-ozawa avatar Feb 20 '24 15:02 momo-ozawa

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr22648-60b3ea1
Version24.5
Bundle IDorg.wordpress.alpha
Commit60b3ea19495ab23e1b9ee3e4fa91c90180b9dad0
App Center BuildWPiOS - One-Offs #9187
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Feb 20 '24 15:02 wpmobilebot

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr22648-60b3ea1
Version24.5
Bundle IDcom.jetpack.alpha
Commit60b3ea19495ab23e1b9ee3e4fa91c90180b9dad0
App Center Buildjetpack-installable-builds #8231
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot avatar Feb 20 '24 15:02 wpmobilebot

I think I get what the icons means here but I think they can also be a bit confusing. What happens when you click on them or when the user clicks on the post?

enejb avatar Feb 21 '24 16:02 enejb

@enejb 👋

The icons besides the "More" buttons indicate that you can tap it to access the options to resolve it (e.g. "Retry", "Discard changes")

p1707228100690759/1707163694.152329-slack-C06GRKUGDNX

In the failed / offline changes state, if a user taps on the post, it will be opened up for editing

momo-ozawa avatar Feb 21 '24 16:02 momo-ozawa