Fix an issue where the All Domains flow wasn't taking into account sites with existing plan
Fixes #22268
Description
This PR resolves an issue where users purchasing a domain, linked to a site that already has a plan, through the All Domains flow get stuck in the Plans flow.
Test Instructions
N.B: Sandboxing is required to test domain checkout
Case 1: Site with Existing Plan
- Log into the site that already has a plan
- Navigate to Me > All Domains
- Tap "+"
- Select a domain
- Tap "Choose Site" button
- Expect the Checkout web view to appear
- Purchase the domain to verify the checkout flow works.
Case 2: Site without plan ( Regression )
- Log into the site that doesn't have a plan
- Navigate to Me > All Domains
- Tap "+"
- Select a domain
- Tap "Get Domain" button
- Expect the Plans web view to appear
- Select a plan, go verify the checkout flow works as expected.
Case 3: Domain with No-Site ( Regression )
- Log into the site that already has a plan
- Navigate to Me > All Domains
- Tap "+"
- Select a domain
- Tap "Get Domain" button
- Expect the Checkout web view to appear
- Purchase the domain to verify the checkout flow works.
Next
- Address the
// TODO:I added inRegisterDomainCoordinator.swift. - Add Unit Tests for
RegisterDomainCoordinator.
Regression Notes
-
Potential unintended areas of impact Purchasing a domain through the All Domains flow.
-
What I did to test those areas of impact (or what existing automated tests I relied on) Manual testing.
-
What automated tests I added (or what prevented me from doing so) None.
PR submission checklist:
- [x] I have completed the Regression Notes.
- [x] I have considered adding unit tests for my changes.
- [x] I have considered adding accessibility improvements for my changes.
- [x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txtif necessary.
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22343-b8b430f | |
| Version | 24.0 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b8b430f2aaef115087adab5accb3815f911487e2 | |
| App Center Build | WPiOS - One-Offs #8551 |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22343-b8b430f | |
| Version | 24.0 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b8b430f2aaef115087adab5accb3815f911487e2 | |
| App Center Build | jetpack-installable-builds #7578 |
@salimbraksa Can you briefly explain how these changes fixed the issue? 🙏
Following Povilas' comment, it appears these changes don't resolve the issue. I'm converting this PR to a Draft and deprioritizing it to focus on the In-App Feedback Prompt UI instead.